Use WebElement.getDomProperty for element src#2538
Merged
labkey-tchad merged 1 commit intorelease25.7-SNAPSHOTfrom Jul 9, 2025
Merged
Use WebElement.getDomProperty for element src#2538labkey-tchad merged 1 commit intorelease25.7-SNAPSHOTfrom
WebElement.getDomProperty for element src#2538labkey-tchad merged 1 commit intorelease25.7-SNAPSHOTfrom
Conversation
labkey-tchad
requested review from
a team and
labkey-chrisj
and removed request for
a team
labkey-chrisj
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
When converting this to not use the deprecated
WebElement.getAttribute, I mistakenly pickedgetDomAttributeto get the src attribute for some thumbnails. Running this test on a server with a contextPath configured revealed this error. Thesrcattribute includes the server's contextPath but our test helpers generally do not expect relative URLs to include the contextPath (e.g./labkey/_webdav/SimpleModuleTest%20Project/%40files/focusPopup.jpg).getDomPropertygets the absolute URL as interpreted by the browser (e.g.http:localhost:8080/labkey/_webdav/SimpleModuleTest%20Project/%40files/focusPopup.jpg).WebElement.getDomAttributegets the literal attribute (el.attributes['src']in JavaScript) butWebElement.getDomPropertygets the attribute as interpreted by the browser (el.srcin JavaScript)Related Pull Requests
Changes
WebElement.getDomPropertyfor elementsrc